You're adding another tank so there's always a chance. They don't usually have issues but like any manufactured piece of equipment it is able to fail.
My advice would be decide the route you're going to go and buy the correct piece. Don't try to save a few bucks making something work that wasn't designed for your exact application.
If you're buying a premade sump I like the aqueon pro flexes because they're quiet. Only downfall is they are made of thinner acrylic so handle it with care and lift it by the bottom, not the sides since they will crack easily with torsion. Other than that they're great sumps. Have used a couple in my home tanks and have installed many. They're dead quiet and the model 3 has a nice sized return chamber with having a decent sized fuge area.
Eshopps sumps are built heavier with thicker acrylic but tend to be pretty noisy unless you put a piece of PVC down from the bulkhead into the filter
sock to discharge the water under the sumps water surface, then you have to pull it out every time you change your filter sock. The AQUEONS you can have an Armani suit on and change the socks without getting the suit wet.
Also custom king on here makes really nice custom acrylic sumps and will design it with you and build it to that exact design.
If going DIY with a glass tank the main advice I'll give you is use glass baffles that way you don't have to worry about the silicone not sticking forever. Also remember to leave room between the baffles and inside of the tank glass for expansion. Glass actually absorbs water throughout the years and will expand slightly. I always left 1/8" - 1/16" on each end to allow for this. Use enough silicone to seal it really well and you'll Have no issues.
If you don't allow for this expansion room there's a chance throughout time with the baffles constantly pushing against the glass after all the panels expand a bit that the pressure cod contribute to a failure.
That's really the main guidelines I always went by. Good luck with your decision. In my honest opinion a sump is worth the small risk. It'll increase your water volume a bit and give your more room to easily accommodate reactors and other equipment you may want to use in the future.